Merged
Conversation
While fully non-blocking the child process adapter is a factor 100 slower than all the other adapters combined, including the blocking fallback adapter. As such removing it wil increase performance for everyone not having ext-uv or ext-eio (coming in a follow-up PR) installed. Even at the cost of blocking for a short period of time.
WyriHaximus
force-pushed
the
0.2.x-drop-child-process-adapter
branch
from
6e50c5d to
3933029
Compare
Member
|
@WyriHaximus I agree that it might be useful to remove the child process adapter for now given the major refactoring (#97 and friends). I still think this might be useful again in the future, but I'm happy to remove any excess code for the time being 👍 (Not sure about the PR labels, I'll add feature and BC break, but feel free to update as you see fit.) |
clue
approved these changes
Aug 26, 2022
Member
Author
|
@clue When the time comes, and we can get it to run it's test in under a second we should consider adding it. But a 100 fold in performance difference is just to big. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fully non-blocking the child process adapter is a factor 100 slower than all the other adapters combined, including the blocking fallback adapter. As such removing it wil increase performance for everyone not having ext-uv or ext-eio (coming in a follow-up PR) installed. Even at the cost of blocking for a short period of time.